Add CI builds for free-threaded Python versions (#150) · python/pythoncapi-compat@718e12e · GitHub

python / pythoncapi-compat Public

• Notifications You must be signed in to change notification settings
• Fork 39
• Star 109

• Code
• Issues 1
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 718e12e

Browse filesBrowse the repository at this point in the historyBrowse files

ngoldbaum

authored

Add CI builds for free-threaded Python versions (#150)

Add missing error-checking in PyLong export tests.

1 parent 5e31710 commit 718e12e
Copy full SHA for 718e12e

2 files changed

+30-5Lines changed: 30 additions & 5 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• .github/workflows
  • build.yml
• tests
  • test_pythoncapi_compat_cext.c

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎.github/workflows/build.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/build.yml

+6Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -27,9 +27,11 @@ jobs:
27	27	- "3.11"
28	28	- "3.12"
29	29	- "3.13"
	30	+ - "3.13t"
30	31	# CPython 3.14 final is scheduled for October 2025:
31	32	# https://peps.python.org/pep-0719/
32	33	- "3.14"
	34	+ - "3.14t"
33	35
34	36	# PyPy versions:
35	37	# - https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md
@@ -68,6 +70,8 @@ jobs:
68	70	python: "3.12"
69	71	- os: windows-latest
70	72	python: "3.13"
	73	+ - os: windows-latest
	74	+ python: "3.13t"
71	75
72	76	# macOS
73	77	# Python 3.9 is the oldest version available on macOS/arm64.
@@ -81,6 +85,8 @@ jobs:
81	85	python: "3.12"
82	86	- os: macos-latest
83	87	python: "3.13"
	88	+ - os: macos-latest
	89	+ python: "3.13t"
84	90
85	91	# Ubuntu: test deadsnakes Python versions which are not supported by
86	92	# GHA python-versions.

Collapse file

‎tests/test_pythoncapi_compat_cext.c‎

Copy file name to clipboardExpand all lines: tests/test_pythoncapi_compat_cext.c

+24-5Lines changed: 24 additions & 5 deletions

Original file line number	Diff line number	Diff line change
@@ -1432,29 +1432,48 @@ test_long_api(PyObject *Py_UNUSED(module), PyObject *Py_UNUSED(args))
1432	1432	PyLongWriter *writer;
1433	1433	static PyLongExport long_export;
1434	1434
1435		- writer = PyLongWriter_Create(1, 1, (void**)&digits);
	1435	+ writer = PyLongWriter_Create(1, 1, (void **)&digits);
	1436	+ if (writer == NULL) {
	1437	+ return NULL;
	1438	+ }
1436	1439	PyLongWriter_Discard(writer);
1437	1440
1438		- writer = PyLongWriter_Create(1, 1, (void**)&digits);
	1441	+ writer = PyLongWriter_Create(1, 1, (void **)&digits);
	1442	+ if (writer == NULL) {
	1443	+ return NULL;
	1444	+ }
1439	1445	digits[0] = 123;
1440	1446	obj = PyLongWriter_Finish(writer);
	1447	+ if (obj == NULL) {
	1448	+ return NULL;
	1449	+ }
1441	1450
1442	1451	check_int(obj, -123);
1443		- PyLong_Export(obj, &long_export);
	1452	+ if (PyLong_Export(obj, &long_export) < 0) {
	1453	+ return NULL;
	1454	+ }
1444	1455	assert(long_export.value == -123);
1445	1456	assert(long_export.digits == NULL);
1446	1457	PyLong_FreeExport(&long_export);
1447	1458	Py_DECREF(obj);
1448	1459
1449		- writer = PyLongWriter_Create(0, 5, (void**)&digits);
	1460	+ writer = PyLongWriter_Create(0, 5, (void **)&digits);
	1461	+ if (writer == NULL) {
	1462	+ return NULL;
	1463	+ }
1450	1464	digits[0] = 1;
1451	1465	digits[1] = 0;
1452	1466	digits[2] = 0;
1453	1467	digits[3] = 0;
1454	1468	digits[4] = 1;
1455	1469	obj = PyLongWriter_Finish(writer);
	1470	+ if (obj == NULL) {
	1471	+ return NULL;
	1472	+ }
1456	1473
1457		- PyLong_Export(obj, &long_export);
	1474	+ if (PyLong_Export(obj, &long_export) < 0) {
	1475	+ return NULL;
	1476	+ }
1458	1477	assert(long_export.value == 0);
1459	1478	digits = (digit*)long_export.digits;
1460	1479	assert(digits[0] == 1);

0 commit comments

Comments

0 (0)