add CI builds for free-threaded Python versions - #150
Merged
vstinner merged 2 commits intoSep 1, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
ngoldbaum
force-pushed
the
free-threaded-ci
branch
2 times, most recently
from
33516bd to
13f1410
Compare
August 26, 2025 20:03
Copy link
Copy Markdown
Contributor
Author
|
I'm confused why there's a complaint about an uninitialized variable, but only on 3.13t under GCC apparently: test_pythoncapi_compat_cext.c: In function ‘test_long_api’:
test_pythoncapi_compat_cext.c:1439:26: error: ‘digits’ may be used uninitialized [-Werror=maybe-uninitialized]
1439 | ((digit *)digits)[0] = 123;
| ~~~~~~~~~~~~~~~~~~~~~^~~~~
test_pythoncapi_compat_cext.c:1431:11: note: ‘digits’ was declared here
1431 | void *digits;
| ^~~~~~
@vstinner do you have any idea what's going wrong? |
Sorry, something went wrong.
ngoldbaum
force-pushed
the
free-threaded-ci
branch
from
13f1410 to
cc249d2
Compare
August 27, 2025 19:54
Copy link
Copy Markdown
Contributor
Author
|
It looks like the missing error checking was tripping up the compiler, but only on 3.13t. Not sure why, but adding error checking fixes it. This is ready now, I think. |
Sorry, something went wrong.
vstinner
approved these changes
Sep 1, 2025
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed there weren't any free-threaded builds for #149.