Add PyMapping_HasKeyWithError() function - #73
Merged
vstinner merged 2 commits intoSep 19, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Add PyMapping_HasKeyWithError() and PyMapping_HasKeyStringWithError() functions. Fix also undefined behavior in PyMapping_GetOptionalItemString() when PyUnicode_FromString() fails: set '*result' to NULL.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Then I will add:
|
Sorry, something went wrong.
Comment thread
tests/test_pythoncapi_compat_cext.c
Outdated
Comment on lines
+53
to
+54
| // Marker to check that pointer value was set | ||
| #define UNINITIALIZED_OBJ ((PyObject *)"uninitialized") |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Sorry, something went wrong.
serhiy-storchaka
approved these changes
Sep 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PyMapping_HasKeyWithError() and PyMapping_HasKeyStringWithError() functions.
Fix also undefined behavior in PyMapping_GetOptionalItemString() when PyUnicode_FromString() fails: set '*result' to NULL.