FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update the copyright by vstinner · Pull Request #9 · python/pythoncapi-compat · GitHub

  1. python
  2. pythoncapi-compat

Repository navigation

Update the copyright - #9

Merged
vstinner merged 1 commit into
mainfrom
license
Apr 22, 2021
ConversationCommits (1)ChecksFiles changed
Merged

Update the copyright#9
vstinner merged 1 commit into
mainfrom
license

Conversation

vstinner commented Apr 22, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

The COPYING file was copied from https://github.com/psf/pyperf/
without updating the copyright.

Follow recommendations of the Linux Foundation:
https://www.linuxfoundation.org/en/blog/copyright-notices-in-open-source-software-projects/

vstinner mentioned this pull request Apr 22, 2021
Closed

vstinner commented Apr 22, 2021

Copy link
Copy Markdown
Member Author

Context of this PR, see: MagicStack/immutables#64

Update the copyright
6d36cbf 
The COPYING file was copied from https://github.com/psf/pyperf/
without updating the copyright.

Follow recommendations of the Linux Foundation:
https://www.linuxfoundation.org/en/blog/copyright-notices-in-open-source-software-projects/

vstinner commented Apr 22, 2021

Copy link
Copy Markdown
Member Author

I updated the PR to use "Copyright Contributors to the pythoncapi_compat project." which is recommended by the Linux Foundation.

vstinner commented Apr 22, 2021

Copy link
Copy Markdown
Member Author

cc @carlwgeorge @elprans @mscherer

elprans approved these changes Apr 22, 2021
View reviewed changes

elprans left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Perhaps also copy the full text of the MIT license to the comment header?

vstinner commented Apr 22, 2021

Copy link
Copy Markdown
Member Author

Perhaps also copy the full text of the MIT license to the comment header?

Nah, I'm lazy :-D IMO "File distributed under the MIT license." and "SPDX-License-Identifier: MIT" is enough.

vstinner merged commit 14c4ade into main Apr 22, 2021
vstinner deleted the license branch April 22, 2021 21:41

vstinner commented Apr 22, 2021

Copy link
Copy Markdown
Member Author

Thanks for the reviews! I'm never comfortable with licenses and copyright :-(

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

corona10 corona10 approved these changes
+1 more reviewer
elprans elprans approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL