Use https for external nav links and correct the Python News hint - #3093
Closed
jefftriplett wants to merge 2 commits into
Closed
Use https for external nav links and correct the Python News hint#3093jefftriplett wants to merge 2 commits into
jefftriplett wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
All external links in the navigation used http and redirected to https. The PSF voting-member link used the pyfound.blogspot.de country domain, which redirects to pyfound.blogspot.com. The Python News item claimed it showed Python Insider posts only. It points at /blogs/, which lists every imported feed.
The News menu linked to the PSF, community and PyCon blogs, but not to blog.python.org itself.
Copy link
Copy Markdown
There was a problem hiding this comment.
Pull request overview
Updates the seeded sitetree navigation fixture to use canonical HTTPS URLs for external News dropdown links and corrects the “Python News” hint/description to better match what the destination page contains.
Changes:
- Switched external navigation URLs in fixtures/sitetree_menus.json from http:// to https:// (including updating the redirected pyfound.blogspot.de URL to the final pyfound.blogspot.com target).
- Updated the “Python News” hint and description text to reflect that the page includes broader Python news and aggregated blog posts (including Python Insider).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to an audit of the News dropdown in fixtures/sitetree_menus.json.
Add Python Insider. The News menu linked to the PSF, community and PyCon blogs, but not to blog.python.org itself. New item pk 126, "Python Insider", sits directly under "Python News". Its siblings shift by one sort_order, so the menu reads: Python News, Python Insider, Community News, PSF News, PyCon News.
Scheme. Every external navigation link used http:// and redirected to https://. I verified each destination with curl and updated the six of them:
Wording. The Python News item (pk 96) said "Python Insider Blog Posts" and described itself as the Core Developer blog. It points at /blogs/, which lists every imported feed, so PSF blog entries appear there as well. The hint and description now describe that. The old wording moves to the new Python Insider item, where it is accurate.
Note: brochure.getpython.info returns 503 over both schemes. That is a separate problem with the destination site, so I left the item in place.
These fixtures are seed data. Production navigation lives in the database, so it needs the same edits applied there.