FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Switch to OIDC for signing login. by zooba · Pull Request #290 · python/release-tools · GitHub

Repository navigation

Switch to OIDC for signing login. - #290

Merged
zooba merged 7 commits into
mainfrom
gh-287
Oct 15, 2025
Merged

zooba merged 7 commits into
mainfrom
gh-287

Conversation

zooba commented Oct 14, 2025

Copy link
Copy Markdown
Member

Also adds the test certificate root CA to work around a signing tool limitation

zooba commented Oct 14, 2025

Copy link
Copy Markdown
Member Author

So the signing tool limitation cannot be worked around, and I believe the signing tool fails during the legacy MSI build because it makes multiple attempts at authentication. The next release of the signing tool will let us set %AZURE_TOKEN_CREDENTIALS%=AzureCliCredential and it should only try one approach, but right now they're using an old library without that support. So we're still using a secret token for legacy builds (which unfortunately means it's still just as vulnerable, but at least we aren't accessing it in most other builds now).

zooba commented Oct 14, 2025

Copy link
Copy Markdown
Member Author

Looks like the final test build passed as well, so this is probably the final form of this PR.

zooba merged commit 17c36be into main Oct 15, 2025
25 checks passed
zooba deleted the gh-287 branch October 15, 2025 19:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL