FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use Github Actions + cibuildwheel for all wheels by hauntsaninja · Pull Request #163 · python/typed_ast · GitHub

This repository was archived by the owner on Jul 5, 2023. It is now read-only.
  1. python
  2. typed_ast

Repository navigation

Use Github Actions + cibuildwheel for all wheels - #163

Merged
srittau merged 5 commits into
python:masterfrom
hauntsaninja:gabuild
Oct 11, 2021
ConversationCommits (5)ChecksFiles changed
Merged

Use Github Actions + cibuildwheel for all wheels#163
srittau merged 5 commits into
python:masterfrom
hauntsaninja:gabuild

Conversation

hauntsaninja commented Oct 11, 2021

Copy link
Copy Markdown
Collaborator

Besides reducing the number of places wheels end up, cibuildwheel does nice things like run auditwheel for you. We also run check-manifest so our sdist is more reliably packaged. Updates to documentation.

This was referenced Oct 11, 2021
Closed
Closed
hauntsaninja mentioned this pull request Oct 11, 2021
Closed
hugovk reviewed Oct 11, 2021
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Very good!

AppVeyor was running the tests, should GHA run tests too?

And can .travis.yml be removed?

Comment thread .github/workflows/build.yml Outdated

on:
push:
branches: [master]

hugovk Oct 11, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I recommend removing this branch restriction, so contributors can test their feature branches before opening PRs.

Relatedly, do you have an example build?

Comment thread release_process.md Outdated
hauntsaninja and others added 3 commits October 10, 2021 22:03
Update release_process.md
e09a4d2 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
run tests, remove travis, don't make release
a5650a5
doc update
db6386a

hauntsaninja commented Oct 11, 2021

Copy link
Copy Markdown
Collaborator Author

Thanks for the feedback!

Example build here: https://github.com/hauntsaninja/typed_ast/actions/runs/1327600384
I changed things to also run tests, so now we can get rid of travis.
I put in the branch restriction because I had the workflow create a github release containing the wheels. But that's more useful for the project I was basing this off of, for typed_ast we can just go to the relevant github actions page and download the artifacts.

hugovk approved these changes Oct 11, 2021
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good!

It's also possible to upload the sdist+wheels to PyPI as part of a release (e.g. tag) using something like https://github.com/pypa/gh-action-pypi-publish, but I'd suggest leaving that for a followup and making a release first with this.

srittau merged commit 7fc8aec into python:master Oct 11, 2021
hauntsaninja deleted the gabuild branch October 11, 2021 19:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
JelleZijlstra JelleZijlstra approved these changes
hugovk hugovk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL