Fix signature of http.client.HTTPSConnection for Python3.12 - #10392
Merged
AlexWaygood merged 4 commits intoJul 1, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sorry, something went wrong.
AlexWaygood
approved these changes
Jul 1, 2023
Comment thread
stdlib/http/client.pyi
| def __init__( | ||
| self, | ||
| host: str, | ||
| port: str | None = None, |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Was it intentional to change this to str? I'm fairly sure this is incorrect...
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source: https://github.com/python/cpython/blob/3.12/Lib/http/client.py#L1441-L1443
I will change http.client.HTTPConnection.get_proxy_response_headers after we will decide on python/cpython#105628