FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

seaborn: mark simple deprecations with typing_extensions.deprecated by hamdanal · Pull Request #11130 · python/typeshed · GitHub

  1. python
  2. typeshed

Repository navigation

seaborn: mark simple deprecations with typing_extensions.deprecated - #11130

Merged
srittau merged 3 commits into
python:mainfrom
hamdanal:seaborn-deprecations
Dec 10, 2023
ConversationCommits (3)ChecksFiles changed
Merged

seaborn: mark simple deprecations with typing_extensions.deprecated#11130
srittau merged 3 commits into
python:mainfrom
hamdanal:seaborn-deprecations

Conversation

hamdanal commented Dec 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note that I intentionally left out deprecated parameters of the big API functions as they would require overloads with very long signatures.

hamdanal commented Dec 9, 2023
View reviewed changes
Comment thread stubs/seaborn/seaborn/algorithms.pyi Outdated
random_seed: _Seed | None = None, # deprecated
) -> NDArray[Any]: ...
@overload
@deprecated("Parameter `random_seed` is deprecated in favor of `seed`")

hamdanal Dec 9, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

https://github.com/mwaskom/seaborn/blob/2bb945c01ad0c18f4c9faa516f0a75e7b89043ec/seaborn/algorithms.py#L45-L49

Comment thread stubs/seaborn/seaborn/axisgrid.pyi
**kwargs: Any,
) -> Self: ...
@property
@deprecated("Attribute `fig` is deprecated in favor of `figure`")

hamdanal Dec 9, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

https://github.com/mwaskom/seaborn/blob/2bb945c01ad0c18f4c9faa516f0a75e7b89043ec/seaborn/axisgrid.py#L47-L54

Comment thread stubs/seaborn/seaborn/distributions.pyi
**kwargs: Any,
) -> FacetGrid: ...
def distplot( # deprecated
@deprecated("Function `distplot` is deprecated and will be removed in seaborn v0.14.0")

hamdanal Dec 9, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

https://github.com/mwaskom/seaborn/blob/2bb945c01ad0c18f4c9faa516f0a75e7b89043ec/seaborn/distributions.py#L2395

Comment thread stubs/seaborn/seaborn/rcmod.pyi
# def set(*args, **kwargs) -> None: ... # deprecated alias for set_theme
set = set_theme

@deprecated("Function `set` is deprecated in favor of `set_theme`")

hamdanal Dec 9, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

https://github.com/mwaskom/seaborn/blob/2bb945c01ad0c18f4c9faa516f0a75e7b89043ec/seaborn/rcmod.py#L126-L132

Comment thread stubs/seaborn/seaborn/utils.pyi
color: ColorType, h: float | None = None, l: float | None = None, s: float | None = None
) -> tuple[float, float, float]: ...
def axlabel(xlabel: str, ylabel: str, **kwargs: Any) -> None: ... # deprecated
@deprecated("Function `axlabel` is deprecated and will be removed in a future version")

hamdanal Dec 9, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

https://github.com/mwaskom/seaborn/blob/2bb945c01ad0c18f4c9faa516f0a75e7b89043ec/seaborn/utils.py#L253-L263

This comment has been minimized.

Sign in to view

hamdanal commented Dec 9, 2023

Copy link
Copy Markdown
Contributor Author

Is the stubtest crash a known issue?

AlexWaygood commented Dec 9, 2023

Copy link
Copy Markdown
Member

Is the stubtest crash a known issue?

Yeah, it's fixed on mypy master, the fix should be included as part of mypy 1.8 :)

This comment has been minimized.

Sign in to view

AlexWaygood commented Dec 9, 2023

Copy link
Copy Markdown
Member

See

hamdanal commented Dec 9, 2023

Copy link
Copy Markdown
Contributor Author

See

Thank you. I just confirmed that the change passes on mypy's release-1.8 branch.

github-actions Bot commented Dec 9, 2023

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

srittau approved these changes Dec 10, 2023
View reviewed changes

srittau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

srittau merged commit 88193cd into python:main Dec 10, 2023
hamdanal deleted the seaborn-deprecations branch December 10, 2023 11:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

srittau srittau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL