Fix pos-only params in os module - #11505
Merged
AlexWaygood merged 3 commits intoFeb 29, 2024
Merged
AlexWaygood merged 3 commits into
AlexWaygood merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This comment has been minimized.
AlexWaygood
reviewed
Feb 29, 2024
Comment thread
stdlib/os/__init__.pyi
Comment on lines
+872
to
+873
| def execl(file: StrOrBytesPath, *args: Unpack[tuple[StrOrBytesPath, Unpack[tuple[StrOrBytesPath, ...]]]]) -> NoReturn: ... | ||
| def execlp(file: StrOrBytesPath, *args: Unpack[tuple[StrOrBytesPath, Unpack[tuple[StrOrBytesPath, ...]]]]) -> NoReturn: ... |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Using PEP646 feels unnecessarily complicated here (and e.g. pytype still doesn't support PEP646 -- it just falls back to Any when it sees Unpack, I believe). Can't we just do this?
Suggested change
| def execl(file: StrOrBytesPath, *args: Unpack[tuple[StrOrBytesPath, Unpack[tuple[StrOrBytesPath, ...]]]]) -> NoReturn: ... | |
| def execlp(file: StrOrBytesPath, *args: Unpack[tuple[StrOrBytesPath, Unpack[tuple[StrOrBytesPath, ...]]]]) -> NoReturn: ... | |
| def execl(file: StrOrBytesPath, arg0: StrOrBytesPath, /, *args: StrOrBytesPath) -> NoReturn: ... | |
| def execlp(file: StrOrBytesPath, arg0: StrOrBytesPath, /, *args: StrOrBytesPath) -> NoReturn: ... |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Yes, looks easier!
Sorry, something went wrong.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Copy link
Copy Markdown
Member
|
Oh interesting. Stubtest is correct; you really can pass file as a keyword argument: >>> import os
>>> os.execl(file='foo')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "<frozen os>", line 548, in execl
ValueError: execv() arg 2 must not be empty |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Hm, this way we have a stubtest problem: error: os.execl is inconsistent, stub argument "file" should be positional or keyword (remove leading double underscore) Stub: in file stdlib/os/__init__.pyi:872 def (Union[builtins.str, builtins.bytes, os.PathLike[builtins.str], os.PathLike[builtins.bytes]], Union[builtins.str, builtins.bytes, os.PathLike[builtins.str], os.PathLike[builtins.bytes]], *args: Union[builtins.str, builtins.bytes, os.PathLike[builtins.str], os.PathLike[builtins.bytes]]) -> Never Runtime: in file /opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/os.py:538 def (file, *args) error: os.execlp is inconsistent, stub argument "file" should be positional or keyword (remove leading double underscore) Stub: in file stdlib/os/__init__.pyi:873 def (Union[builtins.str, builtins.bytes, os.PathLike[builtins.str], os.PathLike[builtins.bytes]], Union[builtins.str, builtins.bytes, os.PathLike[builtins.str], os.PathLike[builtins.bytes]], *args: Union[builtins.str, builtins.bytes, os.PathLike[builtins.str], os.PathLike[builtins.bytes]]) -> Never Runtime: in file /opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/os.py:553 def (file, *args) |
Sorry, something went wrong.
This comment has been minimized.
Copy link
Copy Markdown
Member
|
I guess your PEP646 way is the best way, in that case :) |
Sorry, something went wrong.
AlexWaygood
approved these changes
Feb 29, 2024
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
It is the same notation for __arg1: X, *args: X
Link: https://mypy-play.net/?mypy=latest&python=3.12&gist=b35729b668bf88a0d98a78a8d37c5be1