Update dircmp for 3.13 - #12337
Merged
hauntsaninja merged 5 commits intoAug 5, 2024
Merged
Update dircmp for 3.13#12337hauntsaninja merged 5 commits into
hauntsaninja merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This comment has been minimized.
JelleZijlstra
approved these changes
Jul 13, 2024
JelleZijlstra
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This looks right but we may want to make this param keyword-only: python/cpython#57141 (comment)
Sorry, something went wrong.
Comment thread
stdlib/filecmp.pyi
This comment has been minimized.
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
This comment has been minimized.
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@JelleZijlstra We should be able to go ahead with merging this now. |
Sorry, something went wrong.
hauntsaninja
approved these changes
Aug 5, 2024
max-muoto
added a commit
to max-muoto/typeshed
that referenced
this pull request
Aug 17, 2024
max-muoto
added a commit
to max-muoto/typeshed
that referenced
this pull request
Sep 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add shallow argument: python/cpython#109499