Resolve 3.13 issues for ctypes._endian - #12372
Conversation
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
||
| if sys.version_info >= (3, 12): | ||
| if sys.version_info >= (3, 13): | ||
| from ctypes import Array as Array, Structure, Union |
There was a problem hiding this comment.
Why add Array as new re-export?
Sorry, something went wrong.
There was a problem hiding this comment.
It's exported in the implementation: https://github.com/python/cpython/blob/094375b9b7e087a4f0f60541dc7f2dc53be92646/Lib/ctypes/_endian.py#L2
Sorry, something went wrong.
There was a problem hiding this comment.
It's just imported there. This is a private module, and it doesn't seem like it's intentionally re-exported.
Sorry, something went wrong.
There was a problem hiding this comment.
I see, was trying to match the runtime as closely as possible, but makes sense.
Sorry, something went wrong.
There was a problem hiding this comment.
Sorry, something went wrong.
|
|
||
| if sys.version_info >= (3, 12): | ||
| if sys.version_info < (3, 13): | ||
| from _ctypes import RTLD_GLOBAL as RTLD_GLOBAL, RTLD_LOCAL as RTLD_LOCAL |
There was a problem hiding this comment.
All of these look like incidental re-exports, can we remove all the as imports?
Looks like it used to do from ctypes import *.
Sorry, something went wrong.
There was a problem hiding this comment.
Sorry, something went wrong.
There was a problem hiding this comment.
Let me also add an ignore for older Python versions.
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
|
@JelleZijlstra Should be ready for another look, apologies for the delay. |
Sorry, something went wrong.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sorry, something went wrong.
Starting in 3.13, we're no long doing a star import from ctypes: python/cpython#105768