builtins.slice: more precise __new__ overloads and defaults for StopT and StepT. - #13008
Merged
srittau merged 36 commits intoFeb 28, 2025
Merged
srittau merged 36 commits into
srittau merged 36 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This comment has been minimized.
This comment has been minimized.
randolf-scholz
marked this pull request as ready for review
November 13, 2024 12:22
This comment has been minimized.
Copy link
Copy Markdown
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: mongo-python-driver (https://github.com/mongodb/mongo-python-driver)
- pymongo/synchronous/auth.py:192: error: Argument 1 to "getnameinfo" has incompatible type "tuple[str, int] | tuple[str, int, int, int] | tuple[int, bytes]"; expected "tuple[str, int] | tuple[str, int, int, int]" [arg-type]
- pymongo/asynchronous/auth.py:195: error: Argument 1 to "getnameinfo" has incompatible type "tuple[str, int] | tuple[str, int, int, int] | tuple[int, bytes]"; expected "tuple[str, int] | tuple[str, int, int, int]" [arg-type]
urllib3 (https://github.com/urllib3/urllib3)
- test/contrib/test_socks.py:120: error: Incompatible return value type (got "list[tuple[AddressFamily, SocketKind, int, str, tuple[str, int] | tuple[str, int, int, int] | tuple[int, bytes]]]", expected "list[tuple[AddressFamily, SocketKind, int, str, tuple[str, int] | tuple[str, int, int, int]]]") [return-value]
trio (https://github.com/python-trio/trio)
- src/trio/_socket.py:215: error: Incompatible return value type (got "list[tuple[AddressFamily, SocketKind, int, str, Union[tuple[str, int], tuple[str, int, int, int], tuple[int, bytes]]]]", expected "list[tuple[AddressFamily, SocketKind, int, str, Union[tuple[str, int], tuple[str, int, int, int]]]]") [return-value]
- src/trio/_socket.py:244: error: Argument 1 to "to_thread_run_sync" has incompatible type "Callable[[Union[bytes, str, None], Union[bytes, str, int, None], int, int, int, int], list[tuple[AddressFamily, SocketKind, int, str, Union[tuple[str, int], tuple[str, int, int, int], tuple[int, bytes]]]]]"; expected "Callable[..., list[tuple[AddressFamily, SocketKind, int, str, Union[tuple[str, int], tuple[str, int, int, int]]]]]" [arg-type]
- src/trio/_tests/test_socket.py:130: error: Argument 1 to "MonkeypatchedGAI" has incompatible type "Callable[[Union[bytes, str, None], Union[bytes, str, int, None], int, int, int, int], list[tuple[AddressFamily, SocketKind, int, str, Union[tuple[str, int], tuple[str, int, int, int], tuple[int, bytes]]]]]"; expected "Callable[[Union[str, bytes, None], Union[str, bytes, int, None], int, int, int, int], list[tuple[AddressFamily, SocketKind, int, str, Union[tuple[str, int], tuple[str, int, int, int]]]]]" [arg-type]
|
Sorry, something went wrong.
srittau
approved these changes
Feb 28, 2025
srittau
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Let's start with this PR as it fixes a few primer hits.
Sorry, something went wrong.
This was referenced Feb 28, 2025
mmingyu
pushed a commit
to mmingyu/typeshed
that referenced
this pull request
May 16, 2025
…StopT` and `StepT`. (python#13008)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #12904, letting step default to start|stop (if intersections are ever added, use start&stop)