Extract NetworkX types from docstrings - #13458
Merged
srittau merged 7 commits intoFeb 26, 2025
Merged
srittau merged 7 commits into
srittau merged 7 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sorry, something went wrong.
srittau
approved these changes
Feb 26, 2025
srittau
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Thanks! I found no red flags while spot checking, and the missing primer output is also promising.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry about the huge PR. I have no idea how to validate this. I bet it's not 100% accurate. But it may still be an improvement?
I've mentioned this idea in #11811 but only now did I have the opportunity to work on it. I wrote a small script (networkx_stubs_from_docstrings.py) to extract these annotations from the NetworkX docstrings.
Thanks for any feedback!