Update pip install calls in scripts to use uv. And messages to reference current executable - #13597
Merged
srittau merged 6 commits intoMar 27, 2025
Merged
srittau merged 6 commits into
srittau merged 6 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Akuli
reviewed
Mar 9, 2025
Comment thread
CONTRIBUTING.md
Outdated
…l_third_party_dependencies`
Avasam
commented
Mar 9, 2025
Comment thread
scripts/install_all_third_party_dependencies.py
Outdated
Akuli
reviewed
Mar 10, 2025
Akuli
reviewed
Mar 11, 2025
Akuli
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Nit: We should probably mention this to avoid assuming uv in later changes to this script.
Sorry, something went wrong.
Comment thread
scripts/create_baseline_stubs.py
Akuli
approved these changes
Mar 12, 2025
Copy link
Copy Markdown
Collaborator
Author
|
Post-merge this undoes the changes in #13706 and unconditionally uses uv for that script. Since anything past the installation of requirements-tests.txt we can assume uv will be available. And uv pip respects the currently activated venv. CC @srittau and @donbarbos |
Sorry, something went wrong.
srittau
approved these changes
Mar 27, 2025
mmingyu
pushed a commit
to mmingyu/typeshed
that referenced
this pull request
May 16, 2025
…nce current executable (python#13597)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't force working with a virtual environment nor using a specific name for your venv (uv pip and uv run --active will reuse your activated environment)
Note I didn't touch python/python3 in docs this PR.
I'm also leaving GitHub jobs to a separate self-contained PR.