Sample text for closing future stdlib PRs - #13697
Merged
srittau merged 6 commits intoMar 27, 2025
Merged
srittau merged 6 commits into
srittau merged 6 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
tomasr8
reviewed
Mar 21, 2025
Comment thread
MAINTAINERS.md
Outdated
Comment thread
MAINTAINERS.md
Outdated
Avasam
reviewed
Mar 27, 2025
Comment thread
MAINTAINERS.md
Outdated
| When rejecting a PR for a change for a future Python version, use a message | ||
| like: | ||
|
|
||
| Thanks for contributing! Unfortunately, [as outlined in our CONTRIBUTING document](https://github.com/python/typeshed/blob/main/CONTRIBUTING.md#standard-library-stubs) we only accept pull requests to the standard library for future Python versions after the first beta version has been released. This is in part to prevent churn in the stubs, and in part because the testing infrastructure for the future version is not yet in place. When the first beta version has been released and this PR is still relevant, please feel free to leave a comment here to reopen it. Alternatively, you can open a new PR. |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Alternatively, you can open a new PR.
I initially read this as
Alternatively (to leaving a comment later), you can open a new PR. (now)
but I'm not sure how to make it any clearer without being overly verbose.
Other than that it seems like a perfectly fine message to me.
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
I've switched the two alternatives around. Maybe that is clearer?
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Looks much clearer to me 👍
Sorry, something went wrong.
Avasam
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.