Enable Ruff flake8-builtins (A) - #13729
Merged
AlexWaygood merged 1 commit intoMar 28, 2025
Merged
AlexWaygood merged 1 commit into
AlexWaygood merged 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
srittau
approved these changes
Mar 28, 2025
srittau
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
It's a meh rule, in my opinion, considering that Python built-ins block quite a few important names (filter, id, dir), but I don't mind.
Sorry, something went wrong.
AlexWaygood
approved these changes
Mar 28, 2025
AlexWaygood
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
it's a bit pedantic for sure, but this one seems reasonable to me. The recommendations from this rule are never going to tell you to do something that's actually incorrect, unlike e.g. #13728 (where the more correct thing arguably does sometimes contradict the rule's recommendation)
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #13295
flake8-builtins (A)
At that point, it' easier and more concise to disable the entire group in stubs.
So this group would only apply to our tests/scripts.