FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Improve `oauthlib.common` by donbarbos · Pull Request #13744 · python/typeshed · GitHub

  1. python
  2. typeshed

Repository navigation

Improve oauthlib.common - #13744

Merged
srittau merged 5 commits into
python:mainfrom
donbarbos:improve-oauthlib
Mar 31, 2025
ConversationCommits (5)ChecksFiles changed
Merged

Improve oauthlib.common#13744
srittau merged 5 commits into
python:mainfrom
donbarbos:improve-oauthlib

Conversation

donbarbos commented Mar 30, 2025

Copy link
Copy Markdown
Contributor

No description provided.

This comment has been minimized.

Sign in to view
srittau reviewed Mar 31, 2025
View reviewed changes
Comment thread stubs/oauthlib/oauthlib/common.pyi Outdated

This comment has been minimized.

Sign in to view
srittau requested changes Mar 31, 2025
View reviewed changes

srittau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks, comments below.

Comment thread stubs/oauthlib/oauthlib/common.pyi Outdated
Comment thread stubs/oauthlib/oauthlib/common.pyi Outdated
Comment thread stubs/oauthlib/oauthlib/common.pyi Outdated
Comment thread stubs/oauthlib/oauthlib/common.pyi Outdated
Comment thread stubs/oauthlib/oauthlib/common.pyi Outdated
Comment thread stubs/oauthlib/oauthlib/common.pyi Outdated
Comment thread stubs/oauthlib/oauthlib/common.pyi Outdated
body: str | dict[str, str] | list[tuple[str, str]] | None
decoded_body: list[tuple[str, str]] | None
oauth_params: list[str]
validator_log: dict[str, Any]

srittau Mar 31, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Any needs a comment.

donbarbos Mar 31, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I changed it to object, an example of defining value can be found for example in oauthlib.oauth1.rfc5849.endpoints.resource.ResourceEndpoint.validate_protected_resource_request

donbarbos Mar 31, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

oh I just thought that maybe someone would want to pass a result that could be None, should I add | None for value?

srittau Mar 31, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

object isn't correct, since it would mean that every key can have any object. A suitable comment could be as simple as "# value type depends on the key".

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view
donbarbos changed the title Improve oauthlib Improve oauthlib.common Mar 31, 2025

github-actions Bot commented Mar 31, 2025

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

srittau merged commit 0104531 into python:main Mar 31, 2025
mmingyu pushed a commit to mmingyu/typeshed that referenced this pull request May 16, 2025
Improve oauthlib.common (python#13744)
be40ca6
donbarbos deleted the improve-oauthlib branch February 25, 2026 04:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

srittau srittau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL