Improve oauthlib.oauth2.rfc6749 - #13965
srittau merged 5 commits into
Conversation
Sorry, something went wrong.
This comment has been minimized.
| *args: Any, # actually, these are not used | ||
| **kwargs: Any, # actually, these are not used |
There was a problem hiding this comment.
If they are not used, we should use (_typeshed.)Unused instead of a comment. A potentially better option is to remove the arguments to prevent users from misspelling, e.g. Server(token_genarator=...) isn't an error with the current annotations.
Sorry, something went wrong.
There was a problem hiding this comment.
to be honest i already forgot why i preferred Any, but i think because subclasses can use them
and still I'll probably just remove them
Sorry, something went wrong.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sorry, something went wrong.
No description provided.