| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
For reference, #9548 removed the mentions of incomplete modules from CONTRIBUTING. Since the advent of stubgen, I don't expect many new instances to show up. |
Sorry, something went wrong.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sorry, something went wrong.
There was a problem hiding this comment.
I like the # incomplete module comment instead of just # incomplete
It's also nice to see only a few changes in pyrightconfig.stricter.json.
Sorry, something went wrong.
An included typeshed stub update¹ for docutils (and many other modules) meant that docutils.readers.standalone.Reader became an unknown type and was duly reported as such. We don't care. An apparent regression² results in unnecessary "# type: …" comments in the typeshed itself's internal code being reported as our problem. It is not. Ignore them. ¹ <python/typeshed#13765> <python/typeshed#14030> ² <microsoft/pyright#10487>
An included typeshed stub update¹ for docutils (and many other modules) meant that docutils.readers.standalone.Reader became an unknown type and was duly reported as such. We don't care. An apparent regression² results in unnecessary "# type: …" comments in the typeshed itself's internal code being reported as our problem. It is not. Ignore them. Note that in this case of ignoring out-of-project source, matching an absolute path seems to be required for the Pyright "ignore" pattern to actually work. (I found no relative or partial paths that work.) Also note that whatever globbing Pyright is doing will not match a leading "**" to an absolute path. Give up and anchor the pattern to an absolute root separately for POSIX and Windows. Yay. ¹ <python/typeshed#13765> <python/typeshed#14030> ² <microsoft/pyright#10487>
| Back | FazBrowse Home | New Git URL |
Closes: #13765