FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add additional type ignores for mypy by cdce8p · Pull Request #14050 · python/typeshed · GitHub

  1. python
  2. typeshed

Repository navigation

Add additional type ignores for mypy - #14050

Merged
srittau merged 1 commit into
python:mainfrom
cdce8p:mypy-ignores
May 13, 2025
ConversationCommits (1)ChecksFiles changed
Merged

Add additional type ignores for mypy#14050
srittau merged 1 commit into
python:mainfrom
cdce8p:mypy-ignores

Conversation

cdce8p commented May 13, 2025

Copy link
Copy Markdown
Contributor

See python/mypy#19079

I can reproduce both errors by checking typeshed with the current mypy master commit.

stdlib/tempfile.pyi:387: error: Argument 1 of "writelines" is incompatible with supertype "_IOBase"; supertype defines the argument type as "Iterable[Buffer]"  [override]
stdlib/tempfile.pyi:387: note: This violates the Liskov substitution principle
stdlib/tempfile.pyi:387: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#incompatible-overrides
stdlib/tkinter/ttk.pyi:565: error: Signature of "forget" incompatible with supertype "Pack"  [override]
stdlib/tkinter/ttk.pyi:565: note:      Superclass:
stdlib/tkinter/ttk.pyi:565: note:          def () -> None
stdlib/tkinter/ttk.pyi:565: note:      Subclass:
stdlib/tkinter/ttk.pyi:565: note:          def forget(self, tab_id: Any) -> None

tkinter - Notebook.forget

forget is inherited from Pack.forget but at runtime accepts an additional argument.

typeshed/stdlib/tkinter/__init__.pyi

Lines 1081 to 1084 in 23f1888

def pack_forget(self) -> None: ...
def pack_info(self) -> _PackInfo: ... # errors if widget hasn't been packed
pack = pack_configure
forget = pack_forget

https://www.tcl-lang.org/man/tcl8.6/TkCmd/ttk_notebook.htm#M23

SpooledTemporaryFile.writelines

Not sure it's possible to get the overload right here since the base class definitions seem to conflict itself. _IOBase wants only an Iterable[ReadableBuffer], whereas typing.IO also accepts Iterable[AnyStr].

typeshed/stdlib/_io.pyi

Line 42 in 23f1888

def writelines(self, lines: Iterable[ReadableBuffer], /) -> None: ...

typeshed/stdlib/typing.pyi

Lines 857 to 862 in 23f1888

@abstractmethod
@overload
def writelines(self: IO[bytes], lines: Iterable[ReadableBuffer], /) -> None: ...
@abstractmethod
@overload
def writelines(self, lines: Iterable[AnyStr], /) -> None: ...

/CC @JelleZijlstra

github-actions Bot commented May 13, 2025

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

srittau merged commit 82af3b2 into python:main May 13, 2025
cdce8p deleted the mypy-ignores branch May 13, 2025 14:51
mmingyu pushed a commit to mmingyu/typeshed that referenced this pull request May 16, 2025
Add additional type ignores for mypy (python#14050)
a3a7c9e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

srittau srittau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL