Replace Incomplete | None = None in third party stubs - #14063
srittau merged 13 commits into
Conversation
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This has a remarkably low primer fallout. Publisher.get_settings() has now (correctly) become untyped, which is fine in my opinion. It wasn't really typed previously, either. |
Sorry, something went wrong.
This comment was marked as outdated.
Could you send a separate PR? (It doesn't need to but can include the Incomplete | None = None changes here.) I'll merge it first and then update this PR. |
Sorry, something went wrong.
This comment has been minimized.
|
#14073 for the (unrelated) reportlab stubtest failure. |
Sorry, something went wrong.
Avasam
left a comment
There was a problem hiding this comment.
Quick question/suggestion concerning pyrightconfig.stricter.json. Non-blocker and otherwise LGTM.
And I see it's already suggested in Flake8-PYI: PyCQA/flake8-pyi#509
Sorry, something went wrong.
This comment has been minimized.
Co-authored-by: Avasam <samuel.06@hotmail.com>
|
Diff from mypy_primer, showing the effect of this PR on open source code: sphinx (https://github.com/sphinx-doc/sphinx)
+ sphinx/io.py: note: In function "create_publisher":
+ sphinx/io.py:189:5: error: Call to untyped function "get_settings" in typed context [no-untyped-call]
+ sphinx/builders/html/__init__.py: note: In member "__init__" of class "StandaloneHTMLBuilder":
+ sphinx/builders/html/__init__.py:165:9: error: Call to untyped function "get_settings" in typed context [no-untyped-call]
|
Sorry, something went wrong.
|
CI failure seems unrelated. |
Sorry, something went wrong.
After python#14063, calls to `psutil.process_iter` and `psutil.Process.as_dict` are being reported by Pyright, as the `ad_value` parameter is untyped. However, given that (from the documentation) this is just a placeholder value to use when an error is raised while fetching some attribute, I think that typing it as `object` is appropriate.
Partly addresses #14029