FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make type of `unitest.mock.Any` a subclass of `Any` by donbarbos · Pull Request #14708 · python/typeshed · GitHub

  1. python
  2. typeshed

Repository navigation

Make type of unitest.mock.Any a subclass of Any - #14708

Merged
srittau merged 5 commits into
python:mainfrom
donbarbos:fix-unittest-mock-regression
Sep 14, 2025
ConversationCommits (5)ChecksFiles changed
Merged

Make type of unitest.mock.Any a subclass of Any#14708
srittau merged 5 commits into
python:mainfrom
donbarbos:fix-unittest-mock-regression

Conversation

donbarbos commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

Closes: #14701

brianschubert commented Sep 12, 2025

Copy link
Copy Markdown
Collaborator

Another approach suggested by @srittau is having _ANY inherit from Any (#14701 (comment)). Any thoughts on which approach is preferable?

This comment has been minimized.

Sign in to view
hauntsaninja approved these changes Sep 12, 2025
View reviewed changes

hauntsaninja left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Open to exploring subclass with Any! Might be better, but only real world code examples I can think of where it matters are a little contrived.

sobolevn reviewed Sep 13, 2025
View reviewed changes
Comment thread stdlib/unittest/mock.pyi Outdated

ANY: _ANY
# See https://github.com/python/typeshed/issues/14701
ANY: Any

sobolevn Sep 13, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Do we need class _Any above?

tungol commented Sep 14, 2025

Copy link
Copy Markdown
Contributor

if it's a working solution, I think a subclass of Any is preferable, given that:

>>> type(ANY)
<class 'unittest.mock._ANY'>

This comment has been minimized.

Sign in to view

srittau commented Sep 14, 2025

Copy link
Copy Markdown
Collaborator

LGTM, although we could add some tests to ensure that the problem mentioned in #14701 is fixed. Also, the example from the docs seems worthwhile to add as a test.

brianschubert changed the title [unittest] Revert mock.ANY changes Make type of unitest.mock.Any a subclass of Any Sep 14, 2025
Add tests
e414f10 
I think this is my first attempt at writing type tests, don't judge

This comment has been minimized.

Sign in to view

github-actions Bot commented Sep 14, 2025

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

srittau merged commit 0d100b9 into python:main Sep 14, 2025
63 checks passed
JukkaL mentioned this pull request Sep 15, 2025
Closed
donbarbos mentioned this pull request Sep 23, 2025
Merged
donbarbos deleted the fix-unittest-mock-regression branch February 25, 2026 04:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sobolevn sobolevn left review comments
srittau srittau approved these changes
hauntsaninja hauntsaninja approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Changes to unittest.mock.ANY make it harder to use

6 participants

Back | FazBrowse Home | New Git URL