[functools] Add __slots__ - #15464
Closed
donbarbos wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sorry, something went wrong.
brianschubert
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Hmm, I don't think these actually have __slots__ at runtime. Both partial and _PlaceholderType are implemented in the _functools accelerator module, so the actual runtime types are C types which don't use __slots__:
https://github.com/python/cpython/blob/a7beca8ae3168f1bf191a6be5a2ee5a3009c88c2/Lib/functools.py#L438
>>> import functools
>>> functools.partial.__slots__
Traceback (most recent call last):
File "<python-input-1>", line 1, in <module>
functools.partial.__slots__
AttributeError: type object 'functools.partial' has no attribute '__slots__'. Did you mean '.__class__' instead of '.__slots__'?
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.10: https://github.com/python/cpython/blob/3.10/Lib/functools.py
Changed PR: python/cpython#119827
Python 3.14: https://github.com/python/cpython/blob/3.14/Lib/functools.py