FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

canonicalized set/frozenset signatures by randolf-scholz · Pull Request #15470 · python/typeshed · GitHub

  1. python
  2. typeshed

Repository navigation

canonicalized set/frozenset signatures - #15470

Merged
srittau merged 1 commit into
python:mainfrom
randolf-scholz:set_signatures
Mar 2, 2026
ConversationCommits (1)ChecksFiles changed
Merged

canonicalized set/frozenset signatures#15470
srittau merged 1 commit into
python:mainfrom
randolf-scholz:set_signatures

Conversation

randolf-scholz commented Feb 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Partially Fixes #15271

This PR addressed set/frozenset methods. I replaced Iterable[Any] with iterable[object] as per discussion in #15297

  • Fixed set.discard only accepting T rather than object
  • Fixed set.{difference, difference_update, intersection, intersection_update, isdisjoint, issubset, issuperset} only accepting Iterable[T] rather than Iterable[object]
  • Fixed set.symmetric_difference only accepting Iterable[T] rather than Iterable[S]
  • Fixed frozenset.{isdisjoint, __and__} only accepting Iterable[T] rather than Iterable[object]
  • Fixed frozenset.{__xor__, symmetric_difference} only accepting Iterable[T] rather than Iterable[S]

github-actions Bot commented Feb 28, 2026

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

randolf-scholz mentioned this pull request Feb 28, 2026
Closed
srittau approved these changes Mar 2, 2026
View reviewed changes

srittau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks! These all look reasonable.

srittau merged commit e8638cd into python:main Mar 2, 2026
51 checks passed
srittau mentioned this pull request Mar 2, 2026
Open
1 of 9 tasks
brianschubert mentioned this pull request Mar 15, 2026
Merged
AlexWaygood pushed a commit to astral-sh/ruff that referenced this pull request Mar 15, 2026
Add analysis of typeshed PRs causing ecosystem hits in ruff#23963
2cec91b 
Identifies two typeshed PRs responsible for 139 new ecosystem diagnostics:
- python/typeshed#14284 (dict.__or__ overload removal): ~150 diagnostics
- python/typeshed#15470 (set/frozenset canonicalization): ~3 diagnostics

https://claude.ai/code/session_016z9Bez4viqJyDJAeZMQbWo
AlexWaygood mentioned this pull request Mar 15, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

srittau srittau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Several methods on built-in types are too strict.

2 participants

Back | FazBrowse Home | New Git URL