FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[sys] Add the 3.14 `_jit` 'module' by lambda-abstraction · Pull Request #15692 · python/typeshed · GitHub

/ typeshed Public

[sys] Add the 3.14 _jit 'module' - #15692

Merged
JelleZijlstra merged 13 commits into
python:mainfrom
lambda-abstraction:py314-sys-jit
May 4, 2026
ConversationCommits (13)ChecksFiles changed
Merged

[sys] Add the 3.14 _jit 'module'#15692
JelleZijlstra merged 13 commits into
python:mainfrom
lambda-abstraction:py314-sys-jit

Conversation

lambda-abstraction commented May 2, 2026

Copy link
Copy Markdown
Contributor

Type annotations for sys._jit
To handle the fact that it is a module despite not being importable, i adopted the approach used for sys.monitoring from #10890

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view
AlexWaygood reviewed May 3, 2026
View reviewed changes
Comment thread stdlib/sys/__init__.pyi Outdated

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view
JelleZijlstra reviewed May 3, 2026
View reviewed changes
Comment thread stdlib/@tests/test_cases/sys/check_jit.py Outdated
Remove the claim of the issue cause in the test case, as its not conf…
bcf0601 
…irmed

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

pandas (https://github.com/pandas-dev/pandas)
- pandas/core/computation/ops.py:328: error: Need type annotation for "_binary_ops_dict" (hint: "_binary_ops_dict: dict[<type>, <type>] = ...")  [var-annotated]

JelleZijlstra commented May 4, 2026

Copy link
Copy Markdown
Member

I'm a bit suspicious about the mypy-primer hit, as it seems unrelated to the PR; maybe there's a nondeterminism bug in mypy. I'll investigate that some more.

JelleZijlstra merged commit 483fd73 into python:main May 4, 2026
51 checks passed

srittau commented May 4, 2026

Copy link
Copy Markdown
Collaborator

I'm a bit suspicious about the mypy-primer hit, as it seems unrelated to the PR; maybe there's a nondeterminism bug in mypy. I'll investigate that some more.

We've seen the same primer hit in other PRs. So there's certainly some weirdness, but unrelated to this PR.

JelleZijlstra commented May 4, 2026

Copy link
Copy Markdown
Member

I had Codex look at it and I think it figured it out, I'll send a PR to mypy once I confirm.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes
AlexWaygood AlexWaygood left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL