Remove builtins.ellipsis pseudo-type - #15712
Merged
srittau merged 6 commits intoOct 8, 2026
Merged
srittau merged 6 commits into
srittau merged 6 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This type never existed at runtime, and was replaced by `types.EllipsisType`.
This was referenced May 7, 2026
This comment has been minimized.
hamdanal
added a commit
to hamdanal/typeshed
that referenced
this pull request
Aug 16, 2026
AlexWaygood
pushed a commit
that referenced
this pull request
Aug 16, 2026
This comment has been minimized.
This comment has been minimized.
JelleZijlstra
pushed a commit
to python/mypy
that referenced
this pull request
Aug 29, 2026
Part of #8240 Unblocks python/typeshed#15712 The actual change is one line in checkexpr and the other changes are for tests, mostly mechanical. I used the try except trick used for `types.ModuleType` in the name lookup so that tests that don't import the `types` module don't crash with `KeyError` when they use `...` (which is used in almost all tests as empty function body). Most test changes are caused by modules now correctly resolving to module type instead of `object` because some fixtures started importing `types`. The changes are mine, I only used a coding agent to fix the `fine-grained-modules.test` and `testexportjson.py` tests and the missing visitor method.
Copy link
Copy Markdown
Contributor
|
@srittau we have python/mypy#21911 now. Hopefully it will be included in the next mypy release and this PR will be unblocked. |
Sorry, something went wrong.
This comment has been minimized.
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sorry, something went wrong.
AlexWaygood
approved these changes
Oct 8, 2026
AlexWaygood
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
In pulling this update into ty, our test suite made us aware of the fact that Pydantic 2.13 still uses builtins.ellipsis, so this change results in significantly degraded type-checking for users of Pydantic 2.13. This is fixed in Pydantic 2.14. Maybe this is acceptable, just flagging it since it doesn't seem to have been discussed here. |
Sorry, something went wrong.
bschnurr
added a commit
to microsoft/pyright
that referenced
this pull request
Oct 23, 2026
* Update typeshed to 7030b265d887eeacee07e47aa2cca412b07950c4 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b5fccb8-2031-4188-bdc6-cf3405acbc3f * Adapt ellipsis samples to upstream pseudo-type removal Classification A/C: typeshed commit 0d9b1926fc75ea33c643171b83cea73e3dd9990c (python/typeshed#15712) removes builtins.ellipsis, which never existed at runtime. Use types.EllipsisType to retain exact narrowing expectations, update the builtins symbol list, and remove the obsolete pseudo-type runtime-check case. No reveal expectations are weakened. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b5fccb8-2031-4188-bdc6-cf3405acbc3f --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b5fccb8-2031-4188-bdc6-cf3405acbc3f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This type never existed at runtime, and was replaced by types.EllipsisType.
Part of #7580.