FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

`requests-oauthlib` - remove dependency on `types-requests` because `requests` now comes with its own type annotations by DetachHead · Pull Request #15813 · python/typeshed · GitHub

/ typeshed Public

requests-oauthlib - remove dependency on types-requests because requests now comes with its own type annotations - #15813

Merged
srittau merged 1 commit into
python:mainfrom
DetachHead:patch-3
Jun 9, 2026
ConversationCommits (1)ChecksFiles changed
Merged

requests-oauthlib - remove dependency on types-requests because requests now comes with its own type annotations#15813
srittau merged 1 commit into
python:mainfrom
DetachHead:patch-3

Conversation

DetachHead commented May 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

fixes #15814

srittau requested changes May 20, 2026
View reviewed changes
Comment thread stubs/requests-oauthlib/METADATA.toml Outdated

This comment has been minimized.

Sign in to view
2 similar comments

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view
srittau requested changes May 26, 2026
View reviewed changes

srittau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks, looks mostly good, but we need to add a lower bound for the requests dependencies.

Comment thread stubs/hvac/METADATA.toml Outdated
Comment thread stubs/python-jenkins/METADATA.toml Outdated
Comment thread stubs/slumber/METADATA.toml Outdated
Comment thread stubs/tensorflow/METADATA.toml Outdated

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

DetachHead commented May 26, 2026

Copy link
Copy Markdown
Contributor Author

not sure how to fix that failing job

srittau mentioned this pull request May 26, 2026
Merged

srittau commented May 26, 2026

Copy link
Copy Markdown
Collaborator

Depends on typeshed-internal/stub_uploader#204

srittau approved these changes May 26, 2026
View reviewed changes

srittau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

This comment has been minimized.

Sign in to view
requests-oauthlib - remove dependency on types-requests because `…
7a15f96 
…requests` now comes with its own type annotations

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

DetachHead commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

looks like that stub_uploader fix didn't work? or is there something else i need to change in my PR?

srittau commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Unfortunately, we hard-code a few packages in the stub uploader tests, requests-oauthlib being one of them. I've opened typeshed-internal/stub_uploader#205 to change to another package.

srittau merged commit d3504dd into python:main Jun 9, 2026
76 of 77 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

srittau srittau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

requests-oauthlib should no longer depend on types-requests because requests now comes with its own type annotations

2 participants

Back | FazBrowse Home | New Git URL