msilib: fix type annotation - #15836
Merged
brianschubert merged 4 commits intoJun 6, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This comment has been minimized.
brianschubert
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Thanks! See remarks below
Sorry, something went wrong.
Comment thread
stdlib/msilib/__init__.pyi
Outdated
Comment thread
stdlib/msilib/__init__.pyi
Comment thread
stdlib/msilib/__init__.pyi
Outdated
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sorry, something went wrong.
brianschubert
approved these changes
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm maintaining python-msilib, legacy code borrowed from Python 3.12, intended to allow cx_Freeze's bdist_msi command to continue working in Python 3.13+.
When adding type annotations and type checking, I found some differences.