set_lazy_imports_filter's first arg (importing_module) can be None - #15901
Merged
srittau merged 1 commit intoJun 12, 2026
Merged
set_lazy_imports_filter's first arg (importing_module) can be None#15901srittau merged 1 commit into
srittau merged 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sorry, something went wrong.
srittau
approved these changes
Jun 12, 2026
srittau
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
It's definitely safer if user code handles this edge case.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In real world scenario (see Toufool/AutoSplit@ba2e3d4#diff-37d213d547553f3e9f803b055881175eebb3b15caf26baec90775d81be0389f0 where I was playing around with the new lazy import filtering API) I've hit the first arg being None. I think from exec'd/embedded code (e.g. shiboken6's signature bootstrap)
Weirdly, this is not documented: https://docs.python.org/3.15/library/sys.html#sys.set_lazy_imports_filter
I've considered | MaybeNone, but this is already advanced usage, may as well be correct and let advanced users account for this edge case.