FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make `typing_extensions.TypedDict` a distinct symbol to `typing.TypedDict` by AlexWaygood · Pull Request #15943 · python/typeshed · GitHub

/ typeshed Public

Make typing_extensions.TypedDict a distinct symbol to typing.TypedDict - #15943

Merged
AlexWaygood merged 1 commit into
mainfrom
alex/typeddict
Jun 25, 2026
ConversationCommits (1)ChecksFiles changed
Merged

Make typing_extensions.TypedDict a distinct symbol to typing.TypedDict#15943
AlexWaygood merged 1 commit into
mainfrom
alex/typeddict

Conversation

AlexWaygood commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This would allow ty to remove some hacks...

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

AlexWaygood commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

The full mypy test suite appears to pass with these changes applied. I'm checking the impact this would have on pyright users in AlexWaygood/pyright#2, a PR to my fork of pyright

AlexWaygood commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

The pyright ecosystem check is clean: AlexWaygood/pyright#2 (comment).

@rchen152, would this change cause any problems for pyrefly?

AlexWaygood mentioned this pull request Jun 25, 2026
Merged

rchen152 commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

The pyright ecosystem check is clean: AlexWaygood/pyright#2 (comment).

@rchen152, would this change cause any problems for pyrefly?

Doesn't seem to cause any problems. I pointed pyrefly at a copy of typeshed with this change, and it still recognizes typing_extensions.TypedDict.

AlexWaygood marked this pull request as ready for review June 25, 2026 23:25
AlexWaygood merged commit 4531374 into main Jun 25, 2026
58 checks passed
AlexWaygood deleted the alex/typeddict branch June 25, 2026 23:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL