[peewee] Model.select() type contains the model being selected - #15958
Closed
Psycojoker wants to merge 1 commit into
Closed
[peewee] Model.select() type contains the model being selected#15958Psycojoker wants to merge 1 commit into
Psycojoker wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Psycojoker
force-pushed
the
peewee-Model-select-type-contains-the-model-being-selected
branch
from
d5322b2 to
8c3fcf9
Compare
June 27, 2026 18:31
This comment has been minimized.
Psycojoker
marked this pull request as draft
June 27, 2026 18:56
Psycojoker
force-pushed
the
peewee-Model-select-type-contains-the-model-being-selected
branch
from
56ac553 to
d11e16f
Compare
June 27, 2026 19:17
This comment has been minimized.
Psycojoker
force-pushed
the
peewee-Model-select-type-contains-the-model-being-selected
branch
from
d11e16f to
bc71e0c
Compare
June 27, 2026 19:25
This comment has been minimized.
Psycojoker
marked this pull request as ready for review
June 27, 2026 20:55
[pre-commit.ci] auto fixes from pre-commit.com hooks
Psycojoker
force-pushed
the
peewee-Model-select-type-contains-the-model-being-selected
branch
from
8094c77 to
71f49bf
Compare
June 27, 2026 20:57
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Closed in favor of #15911 (comment) (and the work is likely going to be upstream in peewee itself) |
Sorry, something went wrong.
Psycojoker
deleted the
peewee-Model-select-type-contains-the-model-being-selected
branch
June 28, 2026 13:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
In this kind of code:
This change the type returned by Model.select() from ModelSelect to ModelSelect[MyModel].
I'm not 100% confident about this modification (on if it's the right way to do it) so don't hesitate if you have feedback.
Kind regards,