[peewee] type all "database" call arguments - #15961
Closed
Psycojoker wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Psycojoker
force-pushed
the
peewee-type-all-database-arguments
branch
from
df7da56 to
436ad2c
Compare
June 28, 2026 00:12
This comment has been minimized.
Psycojoker
force-pushed
the
peewee-type-all-database-arguments
branch
from
3b7f56b to
0dd3786
Compare
June 28, 2026 00:40
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Closed in favor of #15911 (comment) (and the work is likely going to be upstream in peewee itself) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Peewee comes with the concept of both a Database object a DatabaseProxy which is a database that doesn't require a connection to be opened immediately: https://docs.peewee-orm.com/en/latest/peewee/api.html#DatabaseProxy
Therefore, I've create a combine type for both and then typed all arguments to method with this new type:
Here are the reference from peewee's documentation:
https://docs.peewee-orm.com/en/latest/peewee/api.html#BaseQuery.execute
https://docs.peewee-orm.com/en/latest/peewee/api.html#BaseQuery.iterator
https://docs.peewee-orm.com/en/latest/peewee/api.html#SelectBase
https://docs.peewee-orm.com/en/latest/peewee/api.html#SelectBase.count
https://docs.peewee-orm.com/en/latest/peewee/api.html#SelectBase.exists
https://docs.peewee-orm.com/en/latest/peewee/api.html#Database.init
For some reason I can't find the "aexecute" in the .pyi file, is it normal? Should I had it myself? I would assume that some tooling was doing this job automatically?
Kind regards,