FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix set xor return types for abstract sets by subotac · Pull Request #16127 · python/typeshed · GitHub

  1. python
  2. typeshed

Repository navigation

Fix set xor return types for abstract sets #16127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
subotac wants to merge 4 commits into
base: main
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
Conversation 7 Commits 4 Checks 87 Files changed
Open

Fix set xor return types for abstract sets #16127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
831c282
Fix set xor return types for abstract sets
subotac Jul 31, 2026
39e1136
Correct set xor signatures for abstract sets
subotac Sep 13, 2026
94a32b3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 13, 2026
043b64a
Merge main and preserve reflected set operator overloads
subotac Oct 11, 2026
File filter

Filter by extension

Filter by extension .py  (1) .pyi  (2) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
12 changes: 12 additions & 0 deletions stdlib/@tests/test_cases/builtins/check_set.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from collections.abc import Set as AbstractSet
from typing_extensions import Literal, assert_type


Expand Down Expand Up @@ -55,3 +56,14 @@ def test_frozenset_interface(s: frozenset[Literal["foo", "bar"]], y: frozenset[s
assert_type(s & y, frozenset[Literal["foo", "bar"]])
assert_type(s | y, frozenset[str])
assert_type(s ^ y, frozenset[str])


def test_xor_with_abstract_set(
s: set[Literal["foo", "bar"]], frozen: frozenset[Literal["foo", "bar"]], other: AbstractSet[str]
) -> None:
s.__xor__(other) # type: ignore
frozen.__xor__(other) # type: ignore
assert_type(other.__rxor__(s), AbstractSet[str])
assert_type(other.__rxor__(frozen), AbstractSet[str])
assert_type(s ^ other, AbstractSet[str])
assert_type(frozen ^ other, AbstractSet[str])
8 changes: 4 additions & 4 deletions stdlib/builtins.pyi
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -1483,10 +1483,10 @@ class set(MutableSet[_T]):
@overload
def __rsub__(self, value: frozenset[_S], /) -> frozenset[_S]: ...

def __xor__(self, value: AbstractSet[_S], /) -> set[_T | _S]: ...
def __xor__(self, value: set[_S] | frozenset[_S], /) -> set[_T | _S]: ... # type: ignore[override]
def __ixor__(self, value: AbstractSet[_T], /) -> Self: ... # type: ignore[override,misc]

@overload
@overload # type: ignore[override]
def __rxor__(self, value: set[_S], /) -> set[_T | _S]: ...
@overload
def __rxor__(self, value: frozenset[_S], /) -> frozenset[_T | _S]: ...
Expand Down Expand Up @@ -1538,9 +1538,9 @@ class frozenset(AbstractSet[_T_co]):
@overload
def __rsub__(self, value: frozenset[_S], /) -> frozenset[_S]: ...

def __xor__(self, value: AbstractSet[_S], /) -> frozenset[_T_co | _S]: ...
def __xor__(self, value: set[_S] | frozenset[_S], /) -> frozenset[_T_co | _S]: ... # type: ignore[override]

@overload
@overload # type: ignore[override]
def __rxor__(self, value: set[_S], /) -> set[_T_co | _S]: ...
@overload
def __rxor__(self, value: frozenset[_S], /) -> frozenset[_T_co | _S]: ...
Expand Down
1 change: 1 addition & 0 deletions stdlib/typing.pyi
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -744,6 +744,7 @@ class AbstractSet(Collection[_T_co]):
def __or__(self, other: AbstractSet[_T], /) -> AbstractSet[_T_co | _T]: ...
def __sub__(self, other: AbstractSet[Any], /) -> AbstractSet[_T_co]: ...
def __xor__(self, other: AbstractSet[_T], /) -> AbstractSet[_T_co | _T]: ...
def __rxor__(self, other: AbstractSet[_T], /) -> AbstractSet[_T_co | _T]: ...
def __eq__(self, other: object, /) -> bool: ...
def isdisjoint(self, other: Iterable[Any], /) -> bool: ...

Expand Down
Loading
Back | FazBrowse Home | New Git URL