Allow keyword errors for UTF-8 decoders - #16447
Open
jw9829 wants to merge 4 commits into
Open
jw9829 wants to merge 4 commits into
jw9829 wants to merge 4 commits into
Conversation
This comment has been minimized.
Comment thread
stdlib/codecs.pyi
Outdated
| @type_check_only | ||
| class _Decoder(Protocol): | ||
| def __call__(self, input: ReadableBuffer, errors: str = ..., /) -> tuple[str, int]: ... # signature of Codec().decode | ||
| def __call__(self, input: ReadableBuffer, /, errors: str = ...) -> tuple[str, int]: ... # signature of Codec().decode |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This is not correct for all codecs:
>>> codecs.lookup("ascii").decode(b"abc", errors="replace")
Traceback (most recent call last):
File "<python-input-3>", line 1, in <module>
codecs.lookup("ascii").decode(b"abc", errors="replace")
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: _codecs.ascii_decode() takes no keyword arguments
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sorry, something went wrong.
Comment thread
stdlib/codecs.pyi
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16441.
The UTF-8 decoder returned by codecs.lookup() accepts errors= as a keyword. Other codecs keep a positional-only signature because some reject keyword arguments.