Improve min/max - #2833
Merged
srittau merged 4 commits intoMar 8, 2019
Merged
Improve min/max#2833srittau merged 4 commits into
srittau merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
srittau
approved these changes
Mar 8, 2019
srittau
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Good fix!
Sorry, something went wrong.
msullivan
added a commit
that referenced
this pull request
Mar 25, 2019
PR #2833 introduced more flexible handling for the type of the default parameter, but the extra type variable caused some issues. Add another overload for the case where there is no default param. This is I think related to the issues we have had with `get` recently?
msullivan
added a commit
that referenced
this pull request
Mar 25, 2019
PR #2833 introduced more flexible handling for the type of the default parameter, but the extra type variable caused some issues. Add another overload for the case where there is no default param. This is I think related to the issues we have had with `get` recently?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably mildly clear if you provide a default value for min/max builtins the return type becomes a 'Union'.
I don't know if that's too much but I also added two other commits (you squash anyway, cherry-pick) because in the recent mypy we can mark positional args via '_' and of course kw only args via '*'.
I didn't find tests. It's also really hard to write this without typos because it's so ... dense. 🤞 hope it helps.
Fixes python/mypy#6460