functools.singledispatchmethod: add __call__ for better results - #3899
Merged
JelleZijlstra merged 3 commits intoApr 4, 2020
Merged
JelleZijlstra merged 3 commits into
JelleZijlstra merged 3 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
It doesn't actually have __call__, it does some descriptor stuff, but this makes things work. _SingleDispatchCallable has a __call__ too, which is what this mirrors. Fixes python#3898
Copy link
Copy Markdown
|
@hauntsaninja Thanks, that was quick! I see Travis is failing on stubtest py38 though 🤔 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It doesn't actually have call, it does some descriptor stuff, but
this makes things work. _SingleDispatchCallable has a call too,
which is what this mirrors.
Fixes #3898