Fix aiofiles type definitions - #4650
Merged
srittau merged 1 commit intoOct 23, 2020
Merged
srittau merged 1 commit into
srittau merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
moriyoshi
force-pushed
the
fix-aiofile-types
branch
from
06edb94 to
01137e0
Compare
October 12, 2020 04:21
moriyoshi
force-pushed
the
fix-aiofile-types
branch
from
01137e0 to
05ad887
Compare
October 12, 2020 04:33
moriyoshi
added a commit
to moriyoshi/starlette
that referenced
this pull request
Oct 14, 2020
JayH5
pushed a commit
to Kludex/starlette
that referenced
this pull request
Oct 14, 2020
* Add type: ignore to make mypy happier * Tentatively ignore type checking failure until the following patch gets merged python/typeshed#4650
Copy link
Copy Markdown
Contributor
Author
|
Can anyone in this project take a look into this? |
Sorry, something went wrong.
srittau
approved these changes
Oct 21, 2020
srittau
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Sorry for the late review. LGTM, but one optional suggestion below.
Sorry, something went wrong.
Comment thread
third_party/3/aiofiles/base.pyi
Copy link
Copy Markdown
|
I'm also encountering this issue and waiting for the fix to be deployed with mypy! |
Sorry, something went wrong.
Closed
hidraco
added a commit
to hidraco/starlette
that referenced
this pull request
Apr 21, 2022
* Add type: ignore to make mypy happier * Tentatively ignore type checking failure until the following patch gets merged python/typeshed#4650
dudleyhunt86
added a commit
to dudleyhunt86/starlette-develop-with-python
that referenced
this pull request
Oct 7, 2022
* Add type: ignore to make mypy happier * Tentatively ignore type checking failure until the following patch gets merged python/typeshed#4650
azurelotus06
added a commit
to azurelotus06/starlette
that referenced
this pull request
Jun 27, 2024
* Add type: ignore to make mypy happier * Tentatively ignore type checking failure until the following patch gets merged python/typeshed#4650
github-actions Bot
pushed a commit
to Kludex/jik
that referenced
this pull request
Aug 16, 2024
* Add type: ignore to make mypy happier * Tentatively ignore type checking failure until the following patch gets merged python/typeshed#4650
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.