Loosen some types to avoid pain in real-life situations - #4870
Merged
ilevkivskyi merged 2 commits intoDec 29, 2020
Merged
ilevkivskyi merged 2 commits into
ilevkivskyi merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: core (https://github.com/home-assistant/core.git)
- homeassistant/helpers/device_registry.py:597: error: Unsupported operand types for - ("Set[str]" and "Set[Optional[str]]") [operator]
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Hm, mypy thinks the overloads are unsafe, I will now try to tweak or ignore to make the build clean. |
Sorry, something went wrong.
srittau
approved these changes
Dec 29, 2020
srittau
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
LGTM, apart from the build failure.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: core (https://github.com/home-assistant/core.git)
- homeassistant/helpers/device_registry.py:597: error: Unsupported operand types for - ("Set[str]" and "Set[Optional[str]]") [operator]
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
For posterity / to keep things linked, set difference was strict-ified in #3886 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this diff:
About the first item, I think mypy should support the overloads on generic self-types (see https://mypy.readthedocs.io/en/stable/more_types.html#restricted-methods-in-generic-classes), but I am not sure about other type-checkers.
cc @JukkaL