Add codecs.unregister() for Python 3.10 - #5539
Merged
srittau merged 2 commits intoMay 27, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
srittau
approved these changes
May 27, 2021
srittau
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
LGTM, but black wants an empty line before the version check.
Sorry, something went wrong.
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
|
The mypy test suite failure is unrelated. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Right, sorry for that. I forgot to enable the pre-commit hook after re-cloning the repo 🤦 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
codecs.unregister() was introduced in Python 3.10