FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make Mapping/MutableMapping params positional-only by JelleZijlstra · Pull Request #5772 · python/typeshed · GitHub

/ typeshed Public

Make Mapping/MutableMapping params positional-only - #5772

Merged
srittau merged 7 commits into
masterfrom
JelleZijlstra-patch-1
Nov 18, 2021
ConversationCommits (7)ChecksFiles changed
Merged

Make Mapping/MutableMapping params positional-only#5772
srittau merged 7 commits into
masterfrom
JelleZijlstra-patch-1

Conversation

JelleZijlstra commented Jul 13, 2021

Copy link
Copy Markdown
Member

These are positional-only on dict, so it makes sense to mark them as positional-only in these base classes too.

Fixes #5771

Make Mapping/MutableMapping params positional-only
668f9b4 
These are positional-only on dict, so it makes sense to mark them as positional-only in these base classes too.

Fixes #5771
JelleZijlstra mentioned this pull request Jul 13, 2021
Closed
JelleZijlstra marked this pull request as draft July 13, 2021 14:27

JelleZijlstra commented Jul 13, 2021

Copy link
Copy Markdown
Member Author

Lots of stubtest complaints about incompatible overrides and runtime inconsistencies. Marking as draft until I resolve those.

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view
JelleZijlstra reopened this Nov 7, 2021

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view
1 similar comment

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view
JelleZijlstra marked this pull request as ready for review November 18, 2021 06:21

github-actions Bot commented Nov 18, 2021

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

srittau merged commit 0d7064c into master Nov 18, 2021
srittau deleted the JelleZijlstra-patch-1 branch November 18, 2021 06:54
jamescooke mentioned this pull request Dec 23, 2021
Closed

sobolevn commented Dec 26, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

@JelleZijlstra this caused this regression: python/mypy#11831

Maybe we can do it other way around? Restore named args in MutableMapping and create incompatible overrides for dict with pos-only args?

JelleZijlstra commented Dec 26, 2021

Copy link
Copy Markdown
Member Author

#6694 does that but I think it's the wrong solution; we can discuss there. (Though note that I'll have limited availability for the next two weeks.)

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

srittau srittau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypeError on built-ins when using keyword arguments is not found

3 participants

Back | FazBrowse Home | New Git URL