FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Improve `wave.open` type with overloads by sobolevn · Pull Request #7000 · python/typeshed · GitHub

  1. python
  2. typeshed

Repository navigation

Improve wave.open type with overloads #7000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srittau merged 2 commits into from
Jan 23, 2022
Conversation 3 Commits 2 Checks 0 Files changed
Merged

Improve wave.open type with overloads #7000

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
577ea1d
Improve `wave.open` type with overloads
sobolevn Jan 23, 2022
d08293a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 23, 2022
File filter

Filter by extension

Filter by extension .pyi  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
8 changes: 6 additions & 2 deletions stdlib/wave.pyi
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import sys
from _typeshed import ReadableBuffer, Self
from typing import IO, Any, BinaryIO, NamedTuple, NoReturn, Union
from typing import IO, Any, BinaryIO, NamedTuple, NoReturn, Union, overload
from typing_extensions import Literal

_File = Union[str, IO[bytes]]
Expand Down Expand Up @@ -62,7 +62,11 @@ class Wave_write:
def writeframes(self, data: ReadableBuffer) -> None: ...
def close(self) -> None: ...

# Returns a Wave_read if mode is rb and Wave_write if mode is wb
@overload
def open(f: _File, mode: Literal["r", "rb"]) -> Wave_read: ...
@overload
def open(f: _File, mode: Literal["w", "wb"]) -> Wave_write: ...
@overload
def open(f: _File, mode: str | None = ...) -> Any: ...

if sys.version_info < (3, 9):
Expand Down
Back | FazBrowse Home | New Git URL