| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sorry, something went wrong.
There was a problem hiding this comment.
This a more precise, so a win in my eyes. I also like that we got rid of some AbstractContextManager inheritance.
Sorry, something went wrong.
|
Thanks! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This PR proposes adding many missing dunder overrides in the stdlib.
Most of these have been omitted because they have similar signatures to the same method in a superclass. However, for all of these methods, the subclass override means that the method can be called with positional-or-keyword arguments, whereas the same method in the superclass can only be called with positional arguments.
It's not a particularly important difference, but, with a patch I'm writing for stubtest (which has other, better effects!), it starts complaining about all of these.
For the vast majority of these, the signature is the same as without this patch applied (modulo the change from positional-only parameters to positional-or-keyword). However, there are a few exceptions where I spotted that a change in signature was required: