tempfile.SpooledTemporaryFile: inherit from IOBase on 3.11 - #7802
Conversation
Sorry, something went wrong.
This comment has been minimized.
AlexWaygood
left a comment
There was a problem hiding this comment.
I'd prefer us to use a wordier-but-more-readable alias name, like _SpooledTemporaryFileBase, rather than _STFBase which feels a bit opaque.
Sorry, something went wrong.
There was a problem hiding this comment.
It looks like in typeshed, we've always pretended that SpooledTemporaryFile has readable() and seekable() methods on Python <3.11 (see the comment on line 330), even though they don't at runtime. This is because SpooledTemporaryFile inherits from IO in typeshed, and IO has readable() and seekable() as abstract methods.
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
AlexWaygood
left a comment
There was a problem hiding this comment.
What about the new detach() method? https://github.com/python/cpython/pull/29560/files#diff-6553a99f3ae04c9fc9c2349ac27037bfe3b274d5ca54d5800d9c5b5f11e29d21R813
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
| # It does not actually derive from IO[AnyStr], but it does mostly behave | ||
| # like one. |
There was a problem hiding this comment.
The comment should probably be moved down above the class itself.
Sorry, something went wrong.
There was a problem hiding this comment.
Done
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sorry, something went wrong.
|
hm, I expected unused stubtest allowlist entries. I'll look into that in a followup PR. |
Sorry, something went wrong.
python/cpython#29560