| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks, one thing I noticed below.
Sorry, something went wrong.
| IO, | ||
| Any, | ||
| AsyncContextManager as AbstractAsyncContextManager, | ||
| ContextManager as AbstractContextManager, |
There was a problem hiding this comment.
This does not re-export, according to PEP 484. (Existing type checkers might still re-export due to __all__, but that is undefined behavior.)
Sorry, something went wrong.
There was a problem hiding this comment.
Interesting, I think we're a little inconsistent about that at the moment, e.g. in our stubs for _collections_abc. Anyhow, I've made the change!
Sorry, something went wrong.
|
Diff from mypy_primer, showing the effect of this PR on open source code: sphinx (https://github.com/sphinx-doc/sphinx)
+ sphinx/util/typing.py: note: In function "_restify_py36":
+ sphinx/util/typing.py:267:26: error: Module has no attribute "GenericMeta"; maybe "Generic"? [attr-defined]
+ sphinx/util/typing.py: note: In function "_stringify_py36":
+ sphinx/util/typing.py:505:33: error: Module has no attribute "GenericMeta"; maybe "Generic"? [attr-defined]
+ sphinx/util/typing.py: note: At top level:
+ sphinx/util/typing.py:507: error: Unused "type: ignore" comment
+ sphinx/util/typing.py:508: error: Unused "type: ignore" comment
+ sphinx/util/typing.py:509: error: Unused "type: ignore" comment
+ sphinx/util/typing.py:510: error: Unused "type: ignore" comment
+ sphinx/util/typing.py:513: error: Unused "type: ignore" comment
+ sphinx/util/typing.py:514: error: Unused "type: ignore" comment
|
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
The first commit here was done using the following script:
DetailsThe second and third commit were done manually.
Closes #6189