Fix UDPServer to correctly inherit from TCPServer - #8542
Merged
AlexWaygood merged 2 commits intoAug 13, 2022
Merged
AlexWaygood merged 2 commits into
AlexWaygood merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This appears to have been added imprecisely to TCPServer, even though the similar entry on UDPServer is guarded.
This comment has been minimized.
PeterJCLaw
force-pushed
the
udp-server-is-a-tcp-server
branch
from
b8ea8d4 to
ef642e0
Compare
August 13, 2022 12:02
This is documented and implemented as such, and means that the signatures of some of the methods (notably __init__) actually differ from those on BaseServer.
PeterJCLaw
force-pushed
the
udp-server-is-a-tcp-server
branch
from
71782b2 to
b144775
Compare
August 13, 2022 12:04
This comment has been minimized.
PeterJCLaw
marked this pull request as ready for review
August 13, 2022 12:13
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sorry, something went wrong.
PeterJCLaw
added a commit
to PeterJCLaw/python-osc
that referenced
this pull request
Aug 13, 2022
PeterJCLaw
added a commit
to PeterJCLaw/python-osc
that referenced
this pull request
Aug 13, 2022
AlexWaygood
approved these changes
Aug 13, 2022
AlexWaygood
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is documented and implemented as such, and means that the signatures of some of the methods (notably __init__) actually differ from those on BaseServer.
This also fixes the definition of the (new in Python 3.11, via python/cpython#30072) allow_reuse_port attribute on these classes that would otherwise have been in conflict with the inheritance change.