add _ctypes.pyi - #8582
Merged
hauntsaninja merged 7 commits intoAug 23, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This comment has been minimized.
Comment thread
stdlib/_ctypes.pyi
Outdated
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
Comment thread
stdlib/_ctypes.pyi
Outdated
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@hauntsaninja Currently, all tests are passed. Is there anything else I should do? |
Sorry, something went wrong.
Closed
AlexWaygood
self-requested a review
August 21, 2022 07:48
AlexWaygood
reviewed
Aug 21, 2022
AlexWaygood
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I know little about ctypes, but this all looks good as far as I can see. Can confirm that COMError takes exactly three arguments on my Windows machine, and _COMError_Details looks good from all the examples I can find online!
Sorry, something went wrong.
hauntsaninja
approved these changes
Aug 23, 2022
This was referenced Aug 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #8571