FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

`asyncore` and `asynchat` will be removed in 3.12 by sobolevn · Pull Request #9033 · python/typeshed · GitHub

/ typeshed Public

asyncore and asynchat will be removed in 3.12 - #9033

Merged
srittau merged 3 commits into
python:mainfrom
sobolevn:asyncore-asynchat-removed
May 23, 2023
ConversationCommits (3)ChecksFiles changed
Merged

asyncore and asynchat will be removed in 3.12#9033
srittau merged 3 commits into
python:mainfrom
sobolevn:asyncore-asynchat-removed

Conversation

sobolevn commented Oct 29, 2022

Copy link
Copy Markdown
Member

AlexWaygood previously requested changes Oct 29, 2022
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The last version in the "version ranges" in this file is the "last version when the module was available" :)

Comment thread stdlib/VERSIONS Outdated
Comment thread stdlib/VERSIONS Outdated

AlexWaygood commented Oct 29, 2022

Copy link
Copy Markdown
Member

I'm also not sure if we should do this before the runtime PR's been merged? But don't have a strong opinion either way on that.

Apply suggestions from code review
aff8dab 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood dismissed their stale review October 29, 2022 11:41

Changes made

This comment has been minimized.

Sign in to view

hauntsaninja commented Oct 29, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

I think stubtest might not complain about missing stubs for stdlib modules, so this is best done when betas are released (in case the removal is undone)

AlexWaygood commented Oct 29, 2022

Copy link
Copy Markdown
Member

I think stubtest might not complain about missing stubs for stdlib modules

That's correct, it doesn't

AlexWaygood added the status: deferred Issue or PR deferred until some precondition is fixed label Oct 29, 2022
AlexWaygood marked this pull request as draft October 30, 2022 11:07
AlexWaygood changed the title asyncore and asynchat will be removed in 3.12 [Wait until 3.12 betas] asyncore and asynchat will be removed in 3.12 Oct 31, 2022
sobolevn removed the status: deferred Issue or PR deferred until some precondition is fixed label May 23, 2023
sobolevn marked this pull request as ready for review May 23, 2023 16:34
sobolevn changed the title [Wait until 3.12 betas] asyncore and asynchat will be removed in 3.12 asyncore and asynchat will be removed in 3.12 May 23, 2023

sobolevn commented May 23, 2023

Copy link
Copy Markdown
Member Author

Beta 1 is out! 👍

github-actions Bot commented May 23, 2023

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

srittau merged commit e666602 into python:main May 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL