urllib: improve bytes handling - #9167
Merged
hauntsaninja merged 3 commits intoNov 23, 2022
Merged
hauntsaninja merged 3 commits into
hauntsaninja merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
JelleZijlstra
commented
Nov 12, 2022
Comment thread
stdlib/urllib/parse.pyi
| @overload | ||
| def urlsplit(url: bytes | bytearray | None, scheme: bytes | None = ..., allow_fragments: bool = ...) -> SplitResultBytes: ... | ||
|
|
||
| if sys.version_info >= (3, 11): |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
python/cpython#25798 removed bytearray support.
Sorry, something went wrong.
JelleZijlstra
commented
Nov 12, 2022
Comment thread
stdlib/urllib/parse.pyi
Outdated
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sorry, something went wrong.
hauntsaninja
approved these changes
Nov 23, 2022
hauntsaninja
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Lgtm
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.