Add __eq__ to types.MappingProxyType - #9580
Merged
AlexWaygood merged 1 commit intoJan 23, 2023
Merged
AlexWaygood merged 1 commit into
AlexWaygood merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The type has a custom __eq__: https://github.com/python/cpython/blob/v3.11.1/Objects/descrobject.c#L1906 This helps fix this mypy false positive when using `--strict-equality`: ``` from types import MappingProxyType p = MappingProxyType({'x': 1}) d = {'x': 1} print(p == d) # error: Non-overlapping equality check ``` The fragment prints `True` so the comparison is valid.
AlexWaygood
approved these changes
Jan 23, 2023
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sorry, something went wrong.
AlexWaygood
added a commit
that referenced
this pull request
Jan 23, 2023
The second parameter is positional-only (I missed this when reviewing #9580)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type has a custom rich comparison function:
https://github.com/python/cpython/blob/v3.11.1/Objects/descrobject.c#L1906
This helps fix this mypy false positive when using --strict-equality:
from types import MappingProxyType p = MappingProxyType({'x': 1}) d = {'x': 1} print(p == d) # error: Non-overlapping equality checkThe fragment prints True so the comparison is valid.